Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add a header to empty files #53

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jisaacstone
Copy link

Python requires package folders to have an 'init.py' file, but usually this file is empty.
Since there is no code in the file adding a copyright header seemed to me to be a bit nonsensical.
I suppose this could be a flag, but I really can't think of why anyone should need a copyright header for an empty file?

Python requries package folders to have an '__init__.py' file, but usually this file is empty.
Since there is no code in the file adding a copyright header seemed to me to be a bit non-sensicle.
I suppose this could be a flag, but I really can't think of why anyone should need a copyright header for an empty file?
@aknysh aknysh self-requested a review March 11, 2019 17:29
Copy link

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jisaacstone
Copy link
Author

Looks like couldn't find the github-linguist package. Updated the Gemspec to look for v7.2, see if that works

@jisaacstone
Copy link
Author

nah yeah that did not work. Sorry I don't actually know ruby at all so I'm not sure exactly what is going on, looks like there is a ~> 6.0 version for github-linguist available (just installed github-linguist-6.4.1 locally) so I don't know why the ci build can't find it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants