Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof P32-P35_P72-P75 #614 (PR 1/2) #782

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

ngsctt
Copy link

@ngsctt ngsctt commented Oct 24, 2020

PR 1 of 2, partially resolves #614, covering pages 0618–0631

I've left the indentation as it was in the file, using tabs instead of spaces. I've also commented out empty lines within comment blocks earlier in the file, to be consistent with the rest of the comment blocks.

I've also left the characters as * (P3800, P4600, P4800).

Corrections made:

  • Page 618
    • R0011 (L32) remove extra hyphen
    • R0014 (L37) remove word "TIME" not in scan
    • R0015 (L38) remove extra hyphen
    • R0021 (L46) (un)correct typo in scan: "FLIGHT" → "FLIGNT"
    • R0043 (L79) remove comma not in scan
    • Comment out empty lines within comment blocks, for consistency
  • Page 619
    • R0045 (L82) add missing period
    • R0054 (L94) correct "BY" → "ON"
    • R0061 (L103) remove extra hyphen
    • R0062 (L105) remove extra hyphen
    • R0066 (L114) remove extra hyphen
    • R0075 (L122) add missing hyphen
    • R0077 (L126) remove word "THE" not in scan
    • Remove line (L131) at end of page (after R0111) not reflected in scan
    • Comment out empty lines within comment blocks, for consistency
  • Page 620
    • R0114 (L134) remove period not in scan
    • Remove empty line (L137) not in scan (after R0116)
    • R0137 (L145) remove extra hyphen
    • R0138 (L146) remove extra hyphen
    • R01395 (L154) remove extra hyphen
    • R01396 (L155) remove extra hyphen
    • R01402 (L162) correct "PROGRAM" → "PROGRAMS"
    • R01404 (L165) remove extra hyphen
    • R01406 (L167) remove extra hyphen
    • R01408 (L169) remove extra hyphen
    • Comment out empty lines within comment blocks, for consistency
  • Page 621 — no discrepancies found
  • Page 622 — no discrepancies found
  • Page 623 — no discrepancies found
  • Page 624
    • Add missing empty line (L325) after P1010
    • R1011 (L325) correct "LOC" → "LOG"; remove extra hyphen
    • R1012 (L325) correct "WHITE, P." → "WHITE.P"; correct "DATE:" → "DATE"; correct "1 JUNE 67" → "1JUNE67"
    • Remove empty line (L327) not in scan (after R1013)
    • R1026 (L347) (un)correct "THEREFORE" → "THERFORE"; remove extra hyphen
    • R1036 (L361) (un)correct "MINIMIZED" → "MINMIZED"
    • Add missing empty line (L365) after R1038
    • R1039 (L368) remove space before tab
  • Page 625
    • R1052 (L386) remove period
    • R1061 (L397) remove extra hyphen
    • R1062 (L399) (un)correct "VEHICLE" → "VEGICLE"; remove extra hyphen
    • R1066 (L404) remove extra hyphen
    • R1069 (L408) remove extra hyphen
    • R1075 (L416) replace period with hyphen
    • R1111 (L424) remove extra hyphen
  • Page 626
    • R1112 (L426) remove extra hyphen
    • R1137 (L437) remove extra hyphen
    • R11394 (L444) correct "DELLVEET2" → "DELVEET2"; remove extra hyphen
    • Remove empty line (L447) before R11402 not in scan
    • R11404 (L450) remove extra hyphen
    • R11405 (L451) remove period
    • R11406 (L452) remove extra hyphen
    • R11407 (L453) remove period
    • R11408 (L454) remove extra hyphen; remove period
    • R11409 (L455) remove period
    • R1141 (L456) remove period
  • Page 627 — no discrepancies found
  • Page 628 — no discrepancies found
  • Page 629
    • P3800 (L572) correct "ADFLAG" → "AVFLAGA"
  • Page 630
    • P4600 (L598) add spaces to match alignment in scan
    • R4652 (L603) added space to reflect alignment in scan
    • 47024 (L612) left as "SXA,1" not "SXA.1"
  • Page 631 — no discrepancies found

http://www.ibiblio.org/apollo/ScansForConversion/Luminary099/0618.jpg

R0011 (L32) remove extra hyphen
R0014 (L37) remove word "TIME" not in scan
R0015 (L38) remove extra hyphen
R0021 (L46) (un)correct typo in scan: "FLIGHT" → "FLIGNT"
R0043 (L79) remove comma not in scan
Comment out empty lines within comment blocks, for consistency
https://www.ibiblio.org/apollo/ScansForConversion/Luminary099/0619.jpg

R0045 (L82) add missing period
R0054 (L94) correct "BY" → "ON"
R0061 (L103) remove extra hyphen
R0062 (L105) remove extra hyphen
R0066 (L114) remove extra hyphen
R0075 (L122) add missing hyphen
R0077 (L126) remove word "THE" not in scan
Remove line (L131) at end of page (after R0111) not reflected in scan
Comment out empty lines within comment blocks, for consistency
https://www.ibiblio.org/apollo/ScansForConversion/Luminary099/0620.jpg

R0114 (L134) remove period not in scan
Remove empty line (L137) not in scan (after R0116)
R0137 (L145) remove extra hyphen
R0138 (L146) remove extra hyphen
R01395 (L154) remove extra hyphen
R01396 (L155) remove extra hyphen
R01402 (L162) correct "PROGRAM" → "PROGRAMS"
R01404 (L165) remove extra hyphen
R01406 (L167) remove extra hyphen
R01408 (L169) remove extra hyphen
Comment out empty lines within comment blocks, for consistency
https://www.ibiblio.org/apollo/ScansForConversion/Luminary099/0624.jpg

Add missing empty line (L325) after P1010
R1011 (L325) correct "LOC" → "LOG"; remove extra hyphen
R1012 (L325) correct "WHITE, P." → "WHITE.P"; correct "DATE:" → "DATE"; correct "1 JUNE 67" → "1JUNE67"
Remove empty line (L327) not in scan (after R1013)
R1026 (L347) (un)correct "THEREFORE" → "THERFORE"; remove extra hyphen
R1036 (L361) (un)correct "MINIMIZED" → "MINMIZED"
Add missing empty line (L365) after R1038
R1039 (L368) remove space before tab
https://www.ibiblio.org/apollo/ScansForConversion/Luminary099/0625.jpg

R1052 (L386) remove period
R1061 (L397) remove extra hyphen
R1062 (L399) (un)correct "VEHICLE" → "VEGICLE"; remove extra hyphen
R1066 (L404) remove extra hyphen
R1069 (L408) remove extra hyphen
R1075 (L416) replace period with hyphen
R1111 (L424) remove extra hyphen
https://www.ibiblio.org/apollo/ScansForConversion/Luminary099/0626.jpg

R1112 (L426) remove extra hyphen
R1137 (L437) remove extra hyphen
R11394 (L444) correct "DELLVEET2" → "DELVEET2"; remove extra hyphen
Remove empty line (L447) before R11402 not in scan
R11404 (L450) remove extra hyphen
R11405 (L451) remove period
R11406 (L452) remove extra hyphen
R11407 (L453) remove period
R11408 (L454) remove extra hyphen; remove period
R11409 (L455) remove period
R1141 (L456) remove period
https://www.ibiblio.org/apollo/ScansForConversion/Luminary099/0630.jpg

P4600 (L598) add spaces to match alignment in scan
R4652 (L603) added space to reflect alignment in scan
47024 (L612) left as "SXA,1" not "SXA.1"
@github-actions github-actions bot added the Type: Proof Comanche55 and Luminary99 files label Oct 24, 2020
@wopian wopian self-requested a review October 24, 2020 17:11
@wopian wopian self-assigned this Oct 24, 2020
@wopian wopian added this to the Luminary099 milestone Oct 24, 2020
@wopian
Copy link
Collaborator

wopian commented Oct 24, 2020

I've also left the characters as * (P3800, P4600, P4800).

These should be corrected to . 👍

@wopian wopian mentioned this pull request Oct 24, 2020
Asterisks in P3800, P4600, P4800 corrected to `.`, per chrislgarry#782 (comment)
@ngsctt
Copy link
Author

ngsctt commented Oct 25, 2020

These should be corrected to . 👍

Fixed in 754153e 🙂

@wopian
Copy link
Collaborator

wopian commented Oct 27, 2020

I've added the hacktoberfest-accepted label to ensure your contribution counts towards Hacktoberfest, as I haven't been able to review as many PRs as I had hoped over the past few days during my free time.

PRs are being throughly reviewed from oldest to newest 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review Needed Type: Proof Comanche55 and Luminary99 files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proof P32-P35_P72-P75
2 participants