Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proxyReqWs): catch socket errors on 0.19.2 #972

Open
wants to merge 1 commit into
base: 0.19.x
Choose a base branch
from

Conversation

Plevi1337
Copy link

This PR fixes issue #1642 on the 0.19.x branch.

Description

The PR copies proposed changes form this comment

Motivation and Context

The issue has already been fixed and closed on newer versions. Unfortunately we are using an older version of angular and one of the core angular libraries use the 0.19.1 version of this package. We've created a private fork with this fix, but figured, someone could use this as well.

How has this been tested?

We've created a fork for a private npm feed. It works well for us.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.

PS

This is my first ever contribution to a public repo. I've tried to follow every policy, as best as I could. Sorry, if I missed something.

@Plevi1337 Plevi1337 marked this pull request as ready for review March 7, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant