Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint-disable-task to disregard *.d.ts files and use recast typescript parser #1352

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

chrisrng
Copy link
Contributor

@chrisrng chrisrng commented Jun 27, 2023

  • Avoid running checkup on autogenerated files
  • Fix parsing issue when given a typescript file by using the typescript parser

Example error:

{"message":{"text":"javascript/eslint-disables generated an error during execution"},"level":"error","associatedRule":{"id":"javascript/eslint-disables"},"exception":{"message":"Error occurred at file.ts. Unexpected token, expected \",\" (24:29)"

@chrisrng chrisrng changed the title Update eslint-disable-task to disregard *.d.ts files Update eslint-disable-task to disregard TS files Jun 27, 2023
@chrisrng chrisrng changed the title Update eslint-disable-task to disregard TS files Update eslint-disable-task to disregard *.d.ts files and use recast typescript parser Jun 27, 2023
@scalvert scalvert merged commit 5fa07b2 into checkupjs:main Jun 27, 2023
3 checks passed
@chrisrng chrisrng deleted the chrisrng-patch-1 branch June 27, 2023 20:51
@scalvert scalvert added the bug Something isn't working label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants