Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mime-types gem to remove logger warnings #316

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Update mime-types gem to remove logger warnings #316

merged 2 commits into from
Jul 27, 2023

Conversation

tarebyte
Copy link
Contributor

This updates the mime-types gem to remove the following warnings:

/app/vendor/bundle/ruby/2.7.0/gems/mime-types-3.2.2/lib/mime/types/logger.rb:30: warning: `_1' is reserved for numbered parameter; consider another name
/app/vendor/bundle/ruby/2.7.0/gems/mime-types-3.2.2/lib/mime/types/logger.rb:30: warning: `_2' is reserved for numbered parameter; consider another name
/app/vendor/bundle/ruby/2.7.0/gems/mime-types-3.2.2/lib/mime/types/logger.rb:30: warning: `_3' is reserved for numbered parameter; consider another name

@tarebyte tarebyte marked this pull request as ready for review July 26, 2023 12:26
issyl0
issyl0 approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were annoying - thanks!

@tarebyte tarebyte merged commit 34ec1bd into main Jul 27, 2023
5 checks passed
@tarebyte tarebyte deleted the tarebyte/update-mime-types branch July 27, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@issyl0 issyl0 issyl0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarebyte @issyl0