Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(verify): remove height check in Verify #216

Merged
merged 3 commits into from
Sep 18, 2024
Merged

feat(verify): remove height check in Verify #216

merged 3 commits into from
Sep 18, 2024

Conversation

cristaloleg
Copy link
Contributor

Remove heightThreshold check in Verify func.

@cristaloleg cristaloleg self-assigned this Sep 9, 2024
Wondertan
Wondertan requested changes Sep 9, 2024
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also remove heightThreshold param, default value and how its overwritten in syncer

@cristaloleg cristaloleg merged commit 4b626c3 into main Sep 18, 2024
4 checks passed
@cristaloleg cristaloleg deleted the oleg/remove-height-check branch September 18, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@vgonkivs vgonkivs vgonkivs approved these changes

@tzdybal tzdybal Awaiting requested review from tzdybal tzdybal is a code owner

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

@gupadhyaya gupadhyaya Awaiting requested review from gupadhyaya gupadhyaya is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

Assignees

@cristaloleg cristaloleg

Labels
kind:break! kind:feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cristaloleg @Wondertan @vgonkivs