Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove cosmos/keyring #227

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jul 14, 2022

Cherry-pick cosmos#12576 on to release/v0.46.x-celestia branch per celestiaorg/celestia-app#548 (comment)

@rootulp rootulp marked this pull request as ready for review July 14, 2022 22:55
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

CHANGELOG.md Outdated Show resolved Hide resolved
@rootulp
Copy link
Collaborator Author

rootulp commented Jul 18, 2022

CI failure looks like a flake:

        	Error:      	Received unexpected error:
        	            	listen tcp 0.0.0.0:41847: bind: address already in use
        	Test:       	TestWithdrawAllSuite

Appears mentioned in cosmos#9010

@evan-forbes evan-forbes merged commit fdac893 into celestiaorg:release/v0.46.x-celestia Jul 20, 2022
@rootulp rootulp deleted the rp/cherry-pick-remove-cosmos-keyring branch July 20, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants