Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive Tags with AILabel #17520

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Sep 18, 2024

It was noticed that we don't have an example with AILabel in Interactive Tag like we do here in the website.

New

  • Added the possibility to added an AILabel inside the Interactive Tags;
  • Added a new stories called With AI Label to show the examples.

Testing / Reviewing

  • Make sure the changes makes sense

@guidari
Copy link
Contributor Author

guidari commented Sep 18, 2024

I’m a little bit concerned about this addition because of the "nested button issue." I tested the screen reader, and everything seems fine. We might be able to overcome this by using non-interactive elements (<div> or <span>) styled and given a role attribute to simulate the appearance and behavior of a button.

Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 6517a06
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66eb0508a445620008246296
😎 Deploy Preview https://deploy-preview-17520--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6517a06
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66eb0508cc333600082454c4
😎 Deploy Preview https://deploy-preview-17520--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ⏱ Backlog
Development

Successfully merging this pull request may close these issues.

1 participant