feat: make pager controlled #693
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(iOS): change Fabric implementation to UIScrollView * fix: fix offset values in vertical orientation * feat: add initialPage props support * feat: add RTL language support * feat: add pageMargin prop support * fix: fix typescript error * feat: remove React.cloneElement * feat(ios): add getPageOffset method * fix: fix styles in old example * fix: behavior on page remove
Co-authored-by: Piotr Trocki <[email protected]>
* feat: rewrite old arch to use UIScrollView * feat: update example styles * fix: sending event on scrollViewDidEndDecelerating * feat: properly calculate width using orientation * fix: change way of disabing scroll * feat: rename to RNCPagerView * fix: removing last page * fix: remove unused properties, set animated
krozniata
requested review from
troZee and
okwasniewski
and removed request for
troZee
troZee
reviewed
Feb 14, 2023
troZee
reviewed
Feb 14, 2023
| @@ -24,6 +24,8 @@ export type OnPageScrollStateChangedEventData = Readonly<{ | |||
| }>; | |||
|
|
|||
| export interface NativeProps extends ViewProps { | |||
| page?: Int32; | |||
There was a problem hiding this comment.
Could you extract those props to a separate interface?
android/src/fabric/java/com/reactnativepagerview/PagerViewViewManager.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/reactnativepagerview/PagerViewViewManagerImpl.kt
Show resolved
Hide resolved
troZee
reviewed
Feb 26, 2023
| val view = PagerViewViewManagerImpl.getViewPager(host) | ||
| Assertions.assertNotNull(view) | ||
| Assertions.assertNotNull(pageIndex) | ||
| val childCount = view.adapter?.itemCount |
There was a problem hiding this comment.
Suggested change
| val childCount = view.adapter?.itemCount | |
| val childCount = view.adapter?.itemCount ?: -1 |
| Assertions.assertNotNull(pageIndex) | ||
| val childCount = view.adapter?.itemCount | ||
| val animated = PagerViewViewManagerImpl.animated | ||
| val canScroll = childCount != null && childCount > 0 && pageIndex >= 0 && pageIndex < childCount |
There was a problem hiding this comment.
Suggested change
| val canScroll = childCount != null && childCount > 0 && pageIndex >= 0 && pageIndex < childCount | |
| val canScroll = childCount > 0 && pageIndex >= 0 && pageIndex < childCount |
|
RN this PR is on hold, bc the sync mechanism in case of failure does not work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes Pager View a controlled component, giving users the ability to control the current page with new
pageandanimatedproperties.It also changes all examples to use the controlled version of Pager View, as this will be the recommended way of using it.
This feature will only be available from version
7.x.xCompatibility
Checklist
README.md