Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add embedded filesystem declaration to --embed example #204

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

camhux
Copy link
Contributor

@camhux camhux commented Sep 16, 2024

Resolves #203. I also added a little flavor text to draw attention to the filesystem line in the example.

I verified with a manual test that instantiating the filesystem with the same name as the caddy.fs module works fine.

Also mention the filesystem explicitly in the preceding sentence
@mholt
Copy link
Member

mholt commented Sep 17, 2024

Thanks! Although, this reminds me, I thought we (not you, don't worry -- separate issue) were going to rename filesystem to file_system 🤔 @mohammed90 Does that ring a bell?

@mholt
Copy link
Member

mholt commented Sep 17, 2024

Oh actually this might be it... caddyserver/caddy#6466 (comment) @elee1766

@mohammed90
Copy link
Member

🤔 @mohammed90 Does that ring a bell?

Yep! Exactly as you said, it's this:

Oh actually this might be it... caddyserver/caddy#6466 (comment) @elee1766

@elee1766
Copy link

oh did I never change it? I'll do it today.

README.md Outdated Show resolved Hide resolved
@mohammed90 mohammed90 merged commit 16f248e into caddyserver:master Sep 20, 2024
7 of 8 checks passed
@mohammed90
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--embed usage example seems incomplete
4 participants