better handler API error parsing. #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possibly we encountered an error while parsing the API error JSON, like connection closes early etc and the received JSON is invalid. Better handle such scenario and build a valid error Dict to keep the exception stack flow running and raise this message to the application. extract the returned text so if we any bit of valid information at least we can pass that to the application. This could be helpfull to if we add calls to the API made for web browser that returns HTML error message, it will fail to decode the recieved error and raise a proper error. closes #1504 Signed-off-by: Alexandre Lavigne <[email protected]>
alifeee
approved these changes
Sep 10, 2024
|
I could possibly manually test it, but that's quiet hard to do. otherwise, using automatic test no 😞 we do not regress in anything so far. |
|
we could make a test that uses a HTTP client and mock the response? |
Possibly yes 🤔 I'm worried how this is gonna play with the cassette recorder too 🤔 it's worth the try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly we encountered an error while parsing the API error JSON, like connection closes early etc and the received JSON is invalid.
Better handle such scenario and build a valid error Dict to keep the exception stack flow running and raise this message to the application.
extract the returned text so if we any bit of valid information at least we can pass that to the application.
This could be helpfull to if we add calls to the API made for web browser that returns HTML error message, it will fail to decode the recieved error and raise a proper error.
closes #1504