-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update keyring & go-keychain for macOS 11 fix #101
Conversation
Otherwise the build fails on macOS 11 Big Sur with: \# github.com/keybase/go-keychain cgo-gcc-prolog:203:11: warning: 'SecTrustedApplicationCreateFromPath' is deprecated: first deprecated in macOS 10.15 - No longer supported [-Wdeprecated-declarations] /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecTrustedApplication.h:59:10: note: 'SecTrustedApplicationCreateFromPath' has been explicitly marked deprecated here See also: 99designs/keyring#56 (comment) 99designs/keyring#66 keybase/go-keychain#55 99designs/aws-vault#427
@@ -37,3 +37,5 @@ require ( | |||
google.golang.org/appengine v1.0.0 // indirect | |||
gopkg.in/alecthomas/kingpin.v2 v2.2.6 | |||
) | |||
|
|||
replace github.com/keybase/go-keychain => github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also change all references from github.com/keybase/go-keychain
to github.com/99designs/go-keychain
, but this indicates we expect the replacement to be temporary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's trickier than that because it's an indirect dependency, via 99designs/keyring; I think we'd have to vendor that and patch its imports too. I guess this is what replace
was made for; I've never used it before, I just cargo-culted @mtibben's comment advice ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a go env setup on macos yet so I can't test this, but it seems fine 👍
Oh you already fixed this! Haha |
Otherwise the build fails on macOS 11 Big Sur with:
Lots more background in: