Check conditions for presence validators to see if an attribute is required #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this since |
lcreid
reviewed
Aug 16, 2023
Comment on lines
+43
to
+45
| if_option = validator.options[:if] | ||
| unless_opt = validator.options[:unless] | ||
| (!if_option || call_with_self(object, if_option)) && (!unless_opt || !call_with_self(object, unless_opt)) |
There was a problem hiding this comment.
So we now handle conditional validators, right?
Comment on lines
+54
to
+56
| validator_class == ActiveModel::Validations::PresenceValidator || | ||
| (defined?(ActiveRecord::Validations::PresenceValidator) && | ||
| target_validators.include?(ActiveRecord::Validations::PresenceValidator)) | ||
| validator_class == ActiveRecord::Validations::PresenceValidator) |
There was a problem hiding this comment.
I've never understood why the second part of the || is going to make a difference.
Comment on lines
+7
to
+11
| if required | ||
| option[:required] = true | ||
| option[:aria] ||= {} | ||
| option[:aria][:required] = true | ||
| end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #691