Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import peerjs correctly (for esinstall to work) #315

Open
wants to merge 1 commit into
base: latest
Choose a base branch
from

Conversation

joust
Copy link
Contributor

@joust joust commented Aug 18, 2023

esinstall fails with the current version of p2p, because it imports Peer as default, whereas the official site doc states otherwise (see https://github.com/peers/peerjs usage). With this fix, esinstall works

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5899132099

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.787%

Totals Coverage Status
Change from base Build 5760693037: 0.0%
Covered Lines: 124
Relevant Lines: 174

💛 - Coveralls

@delucis
Copy link
Member

delucis commented Aug 18, 2023

Thanks for the PR @joust! I wonder if this also depends on the version of Peer JS that is installed 🤔 I know this import style worked previously — although it’s been a long time since I worked on this repo.

I can see in their docs for example that they switched to documenting the default export here: peers/peerjs@d158ea8, but then reverted that commit due to “instability”: peers/peerjs@84e297a

Were you by any chance able to test that this change didn’t break usage in non-esinstall contexts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants