Introduce WalletModel and loadWallet functionality #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
forgot to push some stuff? |
johnny9
force-pushed
the
wallet-model
branch
2 times, most recently
from
7c99b8e
to
df375c0
Compare
MarnixCroes
reviewed
Sep 13, 2024
There was a problem hiding this comment.
- On regtest, I generated a wallet and did generatetoaddress 200
Then the balance was displayed like this
QT:
- regularly it is rather slow or not working
(it's not because they are big unused wallets that need to load, it works fine when using QT)
screencastload.webm
- I've had a couple times that after closing the app the
Saving...window stayed on for multiple minutes while there seems to be no reason as there was no heavy usage that needed to be saved, maybe related to previous point
When a user selects a wallet from the WalletSelect menu the wallet controller can now load the wallet data in and the name and balance will appear in the WalletBadge
johnny9
force-pushed
the
wallet-model
branch
from
df375c0
to
6d02c05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user selects a wallet from the WalletSelect menu the wallet controller can now load the wallet data in and the name and balance will appear in the WalletBadge