Skip to content

Commit

Permalink
Merge #416: add scrollbar to wallet select list
Browse files Browse the repository at this point in the history
ba98b83 qml: add scrollbar to wallet select list (Marnix)

Pull request description:

  This adds a scrollbar to the wallet selection list.

  Addresses #401 (review)

  ---

  ### Images

  scrollbar visible on hover/when scrolling when having more wallets than that are initially visible
  ![image](https://github.com/user-attachments/assets/6cecd990-5e20-48d7-95eb-fcf79cd368d6)

  no scrollbar when not needed:
  ![image](https://github.com/user-attachments/assets/1d9d7418-858a-4576-a1fc-c63ead211919)

  <!--
  *** Please remove the following help text before submitting: ***

  Pull requests without a rationale and clear improvement may be closed
  immediately.

  GUI-related pull requests should be opened against
  https://github.com/bitcoin-core/gui
  first. See CONTRIBUTING.md
  -->

  <!--
  Please provide clear motivation for your patch and explain how it improves
  Bitcoin Core user experience or Bitcoin Core developer experience
  significantly:

  * Any test improvements or new tests that improve coverage are always welcome.
  * All other changes should have accompanying unit tests (see `src/test/`) or
    functional tests (see `test/`). Contributors should note which tests cover
    modified code. If no tests exist for a region of modified code, new tests
    should accompany the change.
  * Bug fixes are most welcome when they come with steps to reproduce or an
    explanation of the potential issue as well as reasoning for the way the bug
    was fixed.
  * Features are welcome, but might be rejected due to design or scope issues.
    If a feature is based on a lot of dependencies, contributors should first
    consider building the system outside of Bitcoin Core, if possible.
  * Refactoring changes are only accepted if they are required for a feature or
    bug fix or otherwise improve developer experience significantly. For example,
    most "code style" refactoring changes require a thorough explanation why they
    are useful, what downsides they have and why they *significantly* improve
    developer experience or avoid serious programming bugs. Note that code style
    is often a subjective matter. Unless they are explicitly mentioned to be
    preferred in the [developer notes](/doc/developer-notes.md), stylistic code
    changes are usually rejected.
  -->

  <!--
  Bitcoin Core has a thorough review process and even the most trivial change
  needs to pass a lot of eyes and requires non-zero or even substantial time
  effort to review. There is a huge lack of active reviewers on the project, so
  patches often sit for a long time.
  -->

  <!--
  Link to github actions build artifacts.

  [![Build Artifacts](https://img.shields.io/badge/Build%20Artifacts-green
  )]()

  -->

ACKs for top commit:
  pablomartin4btc:
    utACK ba98b83
  jarolrod:
    ACK ba98b83

Tree-SHA512: 1013230070913dcb2be6674b9c25acc51c49b8e603b079ca6e6802b3d6b6ce7fabca44a25bef1f641c133b75051d132200573e3d5846c59beb14bcff5edbd34c
  • Loading branch information
hebasto committed Sep 11, 2024
2 parents b979bdc + ba98b83 commit 84c4372
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/qml/pages/wallet/WalletSelect.qml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ Popup {
id: listView
interactive: true
spacing: 2
ScrollBar.vertical: ScrollBar { }
model: walletListModel

delegate: WalletBadge {
Expand Down

0 comments on commit 84c4372

Please sign in to comment.