feat: CE-1014 update web eoc filter to include complaints with a violation type of waste or pesticide in any region #649

barrfalk · 2024-09-19T19:38:05Z

Description

NATCom will now accept the following complaints from WebEOC:

Flag_COS = Yes, or
Violation Type = Pesticide, or
Violation Type = Waste

Fixes # (issue)

How Has This Been Tested?

Create an ERS complaint in WebEOC where the location is not in Peace, and set the violation type to Pesticide. Ensure the complaint appears in NatCom.
Create an ERS complaint in WebEOC where the location is not in Peace, and set the violation type to Waste. Ensure the complaint appears in NatCom.
Create a HWCR complaint in WebEOC where the location is not in Peace. Ensure the complaint does not appear in NatCom.
Create a HWCR complaint in WebEOC where the location is in Peace. Ensure the complaint does appear in NatCom.

Checklist

I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

Further comments

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

Analysis Workflow

After merge, new images are deployed in:

Merge Workflow

…orcement-Complaint (#596) Co-authored-by: Barrett Falk <[email protected]> Co-authored-by: gregorylavery <[email protected]> Co-authored-by: Scarlett <[email protected]> Co-authored-by: Mike <[email protected]> Co-authored-by: Mike Sears <[email protected]>

…etails do not appear in NatCom (#598) Co-authored-by: Barrett Falk <[email protected]> Co-authored-by: gregorylavery <[email protected]> Co-authored-by: Scarlett <[email protected]> Co-authored-by: dmitri-korin-bcps <[email protected]> Co-authored-by: Mike Sears <[email protected]>

Co-authored-by: Barrett Falk <[email protected]> Co-authored-by: Scarlett <[email protected]> Co-authored-by: Mike <[email protected]> Co-authored-by: dmitri-korin-bcps <[email protected]> Co-authored-by: Mike Sears <[email protected]>

Co-authored-by: Barrett Falk <[email protected]>

Co-authored-by: Mike Sears <[email protected]> Co-authored-by: gregorylavery <[email protected]> Co-authored-by: barrfalk <[email protected]>

Co-authored-by: Mike Sears <[email protected]> Co-authored-by: Barrett Falk <[email protected]>

Co-authored-by: Barrett Falk <[email protected]> Co-authored-by: gregorylavery <[email protected]> Co-authored-by: Mike <[email protected]> Co-authored-by: dmitri-korin-bcps <[email protected]> Co-authored-by: Mike Sears <[email protected]>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: afwilcox <[email protected]>

Co-authored-by: afwilcox <[email protected]>

Co-authored-by: Mike Sears <[email protected]> Co-authored-by: Barrett Falk <[email protected]> Co-authored-by: afwilcox <[email protected]>

#613) Co-authored-by: afwilcox <[email protected]>

Co-authored-by: afwilcox <[email protected]>

#623) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: afwilcox <[email protected]>

Co-authored-by: afwilcox <[email protected]>

…#627)

Co-authored-by: Mike Sears <[email protected]>

Co-authored-by: Scarlett <[email protected]> Co-authored-by: Barrett Falk <[email protected]> Co-authored-by: Scarlett <[email protected]> Co-authored-by: afwilcox <[email protected]>

… with bonus typo fixes (#628)

…lds - incorrect toast (#629) Co-authored-by: Mike Sears <[email protected]> Co-authored-by: afwilcox <[email protected]>

Co-authored-by: afwilcox <[email protected]>

Get all flag_COS complaints, or complaints that have a violation type of waste or pesticide.

…ude-complaints-with-a-violation-type-of-Waste-or-Pesticide-in-any-region

afwilcox · 2024-09-20T15:23:00Z

webeoc/src/webeoc-scheduler/webeoc-scheduler.service.ts

-      return response.data as Complaint[];
+      const complaints = response.data as Complaint[];
+      let filteredComplaints: Complaint[];
+      if (flagName === WEBEOC_FLAGS.COMPLAINTS) {


This logic is incorrect. It will only work for complaints but not Updates, Actions Taken or Updates to Actions Taken.

As a result Complaints are being filtered properly but all other messages are going through regardless of if the flag is set or not. E.g. if I create an update for a complaint in Victoria, the complaint is properly filtered out but the update is staged (and promptly errors because it can't find the complaint)

sonarcloud · 2024-09-20T21:43:46Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

dmitri-korin-bcps and others added 30 commits August 26, 2024 07:56

fix: CE-1023 Few layout fixes to actions taken. (#603)

e3dd991

Co-authored-by: Barrett Falk <[email protected]>

feat: CE-1004 outcome attachments for CEEB (#606)

b2cf910

Co-authored-by: Mike Sears <[email protected]> Co-authored-by: gregorylavery <[email protected]> Co-authored-by: barrfalk <[email protected]>

feat: CE-1013 - Update to Logic that Displays Agency Icon (#600)

e2a12f0

Co-authored-by: Mike Sears <[email protected]> Co-authored-by: Barrett Falk <[email protected]>

fix: CE-1004 add plus icon to button (#608)

bd20923

fix: CE-1004-fix-attachment-text-casing (#609)

1cac931

feat: CE-976 Admin screen for CEEB (#605)

b072e01

Co-authored-by: Barrett Falk <[email protected]> Co-authored-by: gregorylavery <[email protected]> Co-authored-by: Mike <[email protected]> Co-authored-by: dmitri-korin-bcps <[email protected]> Co-authored-by: Mike Sears <[email protected]>

feat: CE-1029 - UI Updates to Complaints Tables (#614)

8a4bd67

chore(deps): update jest monorepo (#611)

aff15a7

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: afwilcox <[email protected]>

fix: CE-1036-revert-hwcr-tab-rename (#617)

9c17f3f

fix: Makes the naming in the list consistent. (#618)

18f3ebc

Co-authored-by: afwilcox <[email protected]>

feat: CE-977 create ceeb decison (#607)

d011ecb

Co-authored-by: Mike Sears <[email protected]> Co-authored-by: Barrett Falk <[email protected]> Co-authored-by: afwilcox <[email protected]>

fix: CE-1049 Remove GIR Officer Initials (#622)

ba0cfb9

feat: CE-776 - Keyboard Navigation Improvements - Complaints List Page (

beb8193

#613) Co-authored-by: afwilcox <[email protected]>

feat: CE-1003 Add notes to CEEB complaint outcome (#621)

927ccb6

Co-authored-by: afwilcox <[email protected]>

chore(deps): update postgis/postgis:15-master docker digest to 9e03ed5 (

2c562aa

#623) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: afwilcox <[email protected]>

feat: CE-1028 - Add Close Button to Desktop Filters (#615)

ccbb38c

Co-authored-by: afwilcox <[email protected]>

fix: CE 1052 Reapply the button styling for Species (#624)

d891013

Co-authored-by: afwilcox <[email protected]>

fix: CE 1017 (#619)

cb1e766

Co-authored-by: afwilcox <[email protected]>

fix: Modifies how the contstraint is added to the feature_agency_xref (…

b28a168

…#627)

fix: CE-1055 Remove Margins from decision HR (#625)

49d8048

feat: CE-996-Add Method complaint was received field to Complaint (#626)

a937a6d

feat: CE-1002 Allow CEEB users to capture authorization number (#620)

4a59540

Co-authored-by: Mike Sears <[email protected]>

feat: CE-946-Allow-assignment-of-ceeb-complaints-to-ceeb-officers (#610)

c3eedad

Co-authored-by: Scarlett <[email protected]> Co-authored-by: Barrett Falk <[email protected]> Co-authored-by: Scarlett <[email protected]> Co-authored-by: afwilcox <[email protected]>

fix: CE-1073 and CE-1074 Proper Focus and Validation for Input Groups…

4abcce5

… with bonus typo fixes (#628)

fix: CE-1073: Delay UA transition out effect (#631)

a6fbb03

fix: CE-1056 default filters not showing (#643)

cab1982

fix: CE-1059 Unable to save Decision section without entering all fie…

6d6be66

…lds - incorrect toast (#629) Co-authored-by: Mike Sears <[email protected]> Co-authored-by: afwilcox <[email protected]>

barrfalk and others added 4 commits September 17, 2024 14:01

fix: Image Deletion Issue in Update pr-open.yml (#644)

4ae0f79

Co-authored-by: afwilcox <[email protected]>

Loosen webeoc filter

ed9bedc

Get all flag_COS complaints, or complaints that have a violation type of waste or pesticide.

Update webeoc-scheduler.service.ts

a0a36dc

Merge branch 'release/orca' into CE-1014-Update-WebEOC-Filter-to-incl…

aa65e16

…ude-complaints-with-a-violation-type-of-Waste-or-Pesticide-in-any-region

afwilcox requested changes Sep 20, 2024

View reviewed changes

barrfalk added 5 commits September 20, 2024 08:23

Added actions taken filter to include waste and pesticide

8d89731

Updated filtering for complaint updates

f51cab2

Update webeoc-scheduler.service.ts

3c9380d

Removed duplication

fc7ffc6

Update R__update-insert-complaint-from-staging.sql

1e7dc45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: CE-1014 update web eoc filter to include complaints with a violation type of waste or pesticide in any region #649

feat: CE-1014 update web eoc filter to include complaints with a violation type of waste or pesticide in any region #649

barrfalk commented Sep 19, 2024 •

edited by github-actions bot

Loading

afwilcox Sep 20, 2024

sonarcloud bot commented Sep 20, 2024

feat: CE-1014 update web eoc filter to include complaints with a violation type of waste or pesticide in any region #649

Are you sure you want to change the base?

feat: CE-1014 update web eoc filter to include complaints with a violation type of waste or pesticide in any region #649

Conversation

barrfalk commented Sep 19, 2024 • edited by github-actions bot Loading

Description

How Has This Been Tested?

Checklist

Further comments

afwilcox Sep 20, 2024

Choose a reason for hiding this comment

sonarcloud bot commented Sep 20, 2024

Quality Gate passed

barrfalk commented Sep 19, 2024 •

edited by github-actions bot

Loading