Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file integrity checks to CI workflow #1049

Merged
merged 7 commits into from
Aug 31, 2023
Merged

Conversation

rappizs
Copy link
Contributor

@rappizs rappizs commented Aug 23, 2023

Description

Fixes #1048
Pinned GH actions to specific commit SHA for security reasons.

Type of Change

  • New Feature

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • All new and existing tests pass

@rappizs rappizs force-pushed the file-integrity-checks branch 15 times, most recently from a4100dd to 3bd6b18 Compare August 23, 2023 15:13
@rappizs rappizs marked this pull request as ready for review August 23, 2023 15:14
@rappizs rappizs requested a review from a team as a code owner August 23, 2023 15:14
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@rappizs
Copy link
Contributor Author

rappizs commented Aug 24, 2023

Depends on #1032, merging is blocked for now.

Kuvesz
Kuvesz previously approved these changes Aug 24, 2023
Copy link
Contributor

@Kuvesz Kuvesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once dependency is resolved

pregnor
pregnor previously approved these changes Aug 24, 2023
@rappizs rappizs dismissed stale reviews from pregnor and Kuvesz via 90fbc64 August 24, 2023 13:40
pregnor
pregnor previously approved these changes Aug 24, 2023
@mihaialexandrescu
Copy link
Contributor

Depends on #1032, merging is blocked for now.

#1032 is now merged.

pregnor
pregnor previously approved these changes Aug 30, 2023
Copy link
Contributor

@szykes szykes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comment.

Very welcome change!

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Signed-off-by: Zsolt Rappi <[email protected]>
@rappizs rappizs merged commit 158c5bb into master Aug 31, 2023
6 checks passed
@rappizs rappizs deleted the file-integrity-checks branch August 31, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add file integrity checks to CI pipeline
5 participants