enable pprof #1039
Open
enable pprof #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartam1
requested changes
Aug 15, 2023
main.go
Outdated
| @@ -138,6 +140,7 @@ func main() { | |||
| setupLog.Error(err, "unable to start manager") | |||
| os.Exit(1) | |||
| } | |||
| mgr.AddMetricsExtraHandler("/debug/pprof/", http.HandlerFunc(pprof.Index)) | |||
There was a problem hiding this comment.
We should do this like here: https://github.com/kube-logging/logging-operator/blob/8a8a3ec6bd7764653cc049397d253c53b373a2c7/main.go#L158
There was a problem hiding this comment.
Probably we should also add these:
mgr.AddMetricsExtraHandler("/debug/pprof/cmdline", http.HandlerFunc(pprof.Cmdline))
mgr.AddMetricsExtraHandler("/debug/pprof/profile", http.HandlerFunc(pprof.Profile))
mgr.AddMetricsExtraHandler("/debug/pprof/symbol", http.HandlerFunc(pprof.Symbol))
mgr.AddMetricsExtraHandler("/debug/pprof/trace", http.HandlerFunc(pprof.Trace))
bartam1
reviewed
Aug 31, 2023
main.go
Outdated
| @@ -139,6 +143,14 @@ func main() { | |||
| os.Exit(1) | |||
| } | |||
|
|
|||
| if enableprofile { | |||
| mgr.AddMetricsExtraHandler("/debug/pprof/", http.HandlerFunc(pprof.Index)) | |||
There was a problem hiding this comment.
We need to check the returned error here and for the other mgr.AddMetricsExtraHandler cases.
err = mgr.AddMetricsExtraHandler("/debug/pprof/", http.HandlerFunc(pprof.Index))
if err != nil {
setupLog.Error(err, "unable to attach pprof to webserver")
os.Exit(1)
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
enable pprof for #1038
Type of Change
Checklist