Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(k8scsr_user): nitpicks #1036

Merged
merged 1 commit into from
Aug 15, 2023
Merged

fix(k8scsr_user): nitpicks #1036

merged 1 commit into from
Aug 15, 2023

Conversation

pregnor
Copy link
Member

@pregnor pregnor commented Aug 14, 2023 •
edited
Loading

Description

Couple nitpicks from me on a review for #1036.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe): nitpicks

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@pregnor pregnor requested a review from a team as a code owner August 14, 2023 16:24
@pregnor pregnor mentioned this pull request Aug 14, 2023
Merged
7 tasks
@LuciferInLove LuciferInLove merged commit eaf507b into kafkauser-copy-ca-to-secret Aug 15, 2023
5 checks passed
@LuciferInLove LuciferInLove deleted the pregnor/kafkauser-copy-ca-to-secret branch August 15, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuciferInLove LuciferInLove LuciferInLove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pregnor @LuciferInLove