This repository has been archived by the owner on Oct 16, 2019. It is now read-only.
Create Environment model for better organization #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployment now also stores the sender's username and avatar url which can be used in the future for views. In addition, some indexes were added for optimization.
|
Hi Jey, Are you still interested in getting this merged and/or using this branch? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a private fork of this repository which has quite a few changes which I'd like to push up if you're interested. Fundamentally, nothing is different in terms of deployments, however, we needed a UI for our needs. It's fairly simple but gives great visibility when you have dozens of applications and environments. This PR has some modifications to the models to support it.
Environmentmodel for better organization. This allows us to do grouping and ordering via the database query.Deploymentnow stores the sender's username and avatar url which can be used in the future for views as that information isn't persisted.What are your thoughts on having a UI as part of this repository? It won't perform any actions itself, purely a view of what's been done. If you'd rather not, I suppose I can always keep just that portion in our fork.