Add basic reconciliation between executor RunState and kubernetes #2604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is largely a noop with a few minor changes - Move logging to happen before action is taken - Add logging for when issues self resolve - Don't break out of detectPodIssues - so we can detect more than 1 issue per round -
We can get into the state where the executor RunState thinks there is an active run - but there is no pod backing the run The result of this is that the run can never finish (as there is no pod) and will stay in Pending/Running forever This PR just adds some basic reconciliation so if there is no pod backing the RunState then an action will be taken
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2604 +/- ##
==========================================
+ Coverage 58.60% 58.65% +0.04%
==========================================
Files 236 236
Lines 30357 30458 +101
==========================================
+ Hits 17791 17865 +74
- Misses 11199 11221 +22
- Partials 1367 1372 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
carlocamurri
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can get into the state where the executor RunState thinks there is an active run - but there is no pod backing the run
The result of this is that the run can never finish (as there is no pod) and will stay in Pending/Running forever
This PR just adds some basic reconciliation so if there is no pod backing the RunState then an action will be taken
┆Issue is synchronized with this Jira Task by Unito