Upgrade to Pulsar 3.0.1 (BATCH-318) #2555
Conversation
Update images to Pulsar 3.0.0. That version now has direct support for ARM64 images, so remove references to locally-built ones. Update pulsar-client Go library to latest version. Also, change a `rmdir` invocation to `rm -r` in e2e test target of makefile, in case the .kube directory is not already empty.
richscott
requested review from
suprjinx,
kannon92,
d80tb7,
severinson,
dejanzele and
Sharpz7
Update images to Pulsar 3.0.0. That version now has direct support for ARM64 images, so remove references to locally-built ones. Update pulsar-client Go library to latest version. Also, change a `rmdir` invocation to `rm -r` in e2e test target of makefile, in case the .kube directory is not already empty.
|
I see no problems with this, outside of changing the |
richscott
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2555 +/- ##
==========================================
- Coverage 46.95% 44.61% -2.34%
==========================================
Files 392 373 -19
Lines 43041 39013 -4028
Branches 487 487
==========================================
- Hits 20208 17404 -2804
+ Misses 21319 20363 -956
+ Partials 1514 1246 -268
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Can you add in the new image here as well? https://github.com/armadaproject/armada/blob/master/magefiles/developer.go#L32 |
richscott
changed the title
| @@ -9,6 +9,6 @@ import ( | |||
| const LookoutSql = "lookout/sql" // static asset namespace | |||
|
|
|||
| func init() { | |||
There was a problem hiding this comment.
From this file and below, do you know why these were included? Looks like we committed code unrelated to pulsar upgrade as I hope lookout is unrelated to Pulsar.
There was a problem hiding this comment.
I agree - Lookout is unrelated to Pulsar (as far as I know). When I did the Pulsar 3 upgrade, I had to upgrade the pulsar-client-go library (see the (very few) changes in go.mod), and they changed the signature on about 3 functions to start returning an error (when they returned nothing before). So I fixed our interface definitions that needed those changes, which required regenerating the mocks - that last step caused all the changes in the lookout/lookoutv2 dirs, including that giant statik definition. I thought about seeing if I could revert some of the files that were changed by generate, but compilation and testing quickly failed, so I just stayed with clean generated updates (I did no manual tweaks to those files after running the generate step).
richscott
changed the title
Update Pulsar images to version 3.0.0. That version now has direct support for ARM64 images, so remove references to locally-built ones. Update pulsar-client Go library to latest version (v0.10.0).
Also, change a
rmdirinvocation torm -rin e2e test target of makefile, in case the .kube directory is not already empty.Some mocks had to be regenerated (via
make generatetarget) as the newpulsar-client-goversion now hasConsumer.Ack(Message)andConsumer.AckID(msgID)returning anerror.All unit tests, plus the
tests-e2eandtests-e2e-airflowintegration tests pass successfully, with these changes.These changes won't be merged until approved and/or tested by GR devs.
Fixes https://gr-oss.atlassian.net/browse/BATCH-318
┆Issue is synchronized with this Jira Task by Unito