[Proposal] SOAR-0011: Improved error handling #626
+152
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please also add a link to it in the Proposals.md file 🙂 |
czechboy0
requested changes
Sep 17, 2024
There was a problem hiding this comment.
Great work, thank you @gayathrisairam!
Added a few comments that are meant to help prepare the proposal for review (I'll hold off on commenting on the proposal itself for the review period).
Once you make these updates, we'll be able to send out the proposal for wider review.
Sources/swift-openapi-generator/Documentation.docc/Proposals/SOAR-0011.md
Outdated
Show resolved
Hide resolved
Sources/swift-openapi-generator/Documentation.docc/Proposals/SOAR-0011.md
Outdated
Show resolved
Hide resolved
Sources/swift-openapi-generator/Documentation.docc/Proposals/SOAR-0011.md
Outdated
Show resolved
Hide resolved
Sources/swift-openapi-generator/Documentation.docc/Proposals/SOAR-0011.md
Outdated
Show resolved
Hide resolved
Sources/swift-openapi-generator/Documentation.docc/Proposals/SOAR-0011.md
Outdated
Show resolved
Hide resolved
…OAR-0011.md Co-authored-by: Honza Dvorsky <[email protected]>
…OAR-0011.md Co-authored-by: Honza Dvorsky <[email protected]>
…OAR-0011.md Co-authored-by: Honza Dvorsky <[email protected]>
Link to what? |
Here, a link to your proposal: |
czechboy0
changed the title
czechboy0
changed the title
|
The proposal is now In Review, forums thread: https://forums.swift.org/t/proposal-soar-0011-improved-error-handling/74736 |
czechboy0
reviewed
Sep 19, 2024
|
|
||
| - Proposal: SOAR-0011 | ||
| - Author(s): [Gayathri Sairamkrishnan](https://github.com/gayathrisairam) | ||
| - Status: **Awaiting Review** |
There was a problem hiding this comment.
Suggested change
| - Status: **Awaiting Review** | |
| - Status: **In Review** |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Swift OpenAPI runtime doesn't allow for fine grained error handling. This PR adds a proposal for improved error handling in Swift OpenAPI runtime.
Modifications
(See the proposal for details)
Result
n/a
Test Plan
n/a