Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for protobuf version range, breaks with v3 protobuf #456

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

3dprintscanner
Copy link

@3dprintscanner 3dprintscanner commented May 4, 2019

Building source as per from with the USE_MODULES=ON flag pulls in protobuf 3.3.0 and the compilation fails with message /src/caffe.pb.cc:31115:35: error: ‘MergeFromFail’ is not a member of ‘google::protobuf::internal’ ::google::protobuf::internal::MergeFromFail(__FILE__, __LINE__);

This is caused by the caffe.proto file being built against the proto 2.xx schema end emitting a c++ file with a call to MergeFromFail which was deprecated in the 3.x.x version of
protobuf.

This is a temp message to show the compatibility requirements to get a functional build.

Full solution is to migrate to v3 protobuf or remove dependency entirely

edit: can remove caffe

@nudles
Copy link
Member

nudles commented May 4, 2019

if it is the problem of the proto 2.xx scheme, should fix this issue by upgrading the scheme to v3? instead of just changing the documentation?

@3dprintscanner
Copy link
Author

if it is the problem of the proto 2.xx scheme, should fix this issue by upgrading the scheme to v3? instead of just changing the documentation?

@nudles Looks like it's possible to do that, however default values are deprecated in protobuf 3.0 and the caffe.proto file has some non-standard defaults set, not sure how those get handled in all the code consuming those objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants