Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-1584] Implement the sidecar injector of kubernetes #85

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ChinX
Copy link
Contributor

@ChinX ChinX commented Nov 11, 2019

No description provided.

@tianxiaoliang
Copy link
Contributor

inject is a verb which can not be used as pkg name

@tianxiaoliang
Copy link
Contributor

proxy-injector is not suitable for a pkg name

@tianxiaoliang
Copy link
Contributor

add doc plz

@ChinX
Copy link
Contributor Author

ChinX commented Nov 12, 2019

add doc plz

Ok, the status of the PR is "working in progress" and I will complete it in future commits.

@ChinX
Copy link
Contributor Author

ChinX commented Nov 12, 2019

inject is a verb which can not be used as pkg name

Ok, I will modify it.

@ChinX
Copy link
Contributor Author

ChinX commented Nov 12, 2019

proxy-injector is not suitable for a pkg name

Ok, I will modify it.

proxy-injector/inject/config.go Outdated Show resolved Hide resolved
proxy-injector/inject/config.go Outdated Show resolved Hide resolved
@tianxiaoliang
Copy link
Contributor

doc plz

@WillemJiang
Copy link
Member

@ChinX Is there update on this PR?

@WillemJiang
Copy link
Member

Please use the JIRA to check the issue, otherwise it's impossible for us to generate the release note for JIRA.

injector/cmd/start.go Outdated Show resolved Hide resolved
injector/templates/servicecomb/config.go Outdated Show resolved Hide resolved
injector/templates/servicecomb/config.go Outdated Show resolved Hide resolved
injector/templates/servicecomb/servicecomb.go Outdated Show resolved Hide resolved
injector/webhook/options.go Outdated Show resolved Hide resolved
@tianxiaoliang
Copy link
Contributor

交付使用文档

@ChinX ChinX force-pushed the master branch 2 times, most recently from 0f5d24a to 192f616 Compare December 17, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants