OAK-11094: Allow creating Segment with a provided SegmentData #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicolapps
changed the title
Nicolapps
force-pushed
the
OAK-11094
branch
from
c725d14
to
7249f3c
Compare
mreutegg
reviewed
Sep 12, 2024
oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/Segment.java
Outdated
Show resolved
Hide resolved
mreutegg
requested changes
Sep 13, 2024
oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/SegmentTest.java
Outdated
Show resolved
Hide resolved
mreutegg
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All currently existing constructors of
Segmentinstantiate aSegmentDatainstance from the provided data buffer (eitherbyte[]ororg.apache.jackrabbit.oak.commons.Buffer)In some cases where we would like to use a custom implementation of
SegmentData, it could be helpful to have a constructor that takes aSegmentDatainstance instead.This PR also makes
SegmentReferencesandRecordNumberpublic so that the constructor I’m adding can also be public.Closes OAK-11094