OAK-11042: bump elastic 8.15.0 / lucene 9.11.1 #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziofortino
requested review from
nit0906,
nfsantos,
thomasmueller and
amit-jain
nfsantos
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Just requested a few minor changes.
Additionally, it would be nice to log the values of the configuration properties of the class, for instance, of oak.indexer.elastic.bulkProcessorConcurrency. I use https://github.com/apache/jackrabbit-oak/blob/trunk/oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/ConfigHelper.java.
.../java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticBulkProcessorHandler.java
Outdated
Show resolved
Hide resolved
…ILED_DOC_COUNT_FOR_STATUS_NODE
|
@nfsantos I agree it would be nice to log the values of the configuration properties. To do this properly we should do some refactoring by moving the ConfigHelper somewhere else (eg: oak-commons). This should be done in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes workaround for BulkIngester issue that should be addressed by this PR elastic/elasticsearch-java#867