Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review create default values and small rework #1100

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ath0mas
Copy link
Contributor

@ath0mas ath0mas commented Apr 18, 2021

Platforms affected

iOS

Motivation and Context

Mixed default values for create between cli doc, cordova-android and cordova-ios.

Description

Package ids were mostly correct but not all, and same for project name. Suggested proper defaults:

  • id / package name: io.cordova.helloCordova
  • name / project name: Hello Cordova

See linked PRs: apache/cordova-cli#554, apache/cordova-android#1213

And

  • mimic code from cordova-android for createProject on how to init and deal with its parameters
  • remove useless check on project_parent as fs.ensureDirSync is used

(see each commit for detail on my steps)

Testing

npm test success

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@a3a3936). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1100   +/-   ##
=========================================
  Coverage          ?   74.88%           
=========================================
  Files             ?       13           
  Lines             ?     1724           
  Branches          ?        0           
=========================================
  Hits              ?     1291           
  Misses            ?      433           
  Partials          ?        0           
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/Podfile.js 73.20% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3a3936...84a2eea. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants