git workflow added #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #26 diff @@
===================================
Files 5 5
Lines 162 162
Methods 0 0
Messages 0 0
Branches 0 0
===================================
Hits 162 162
Misses 0 0
Partials 0 0
|
|
@vibrantabhi19, keep up the good work. While the GitHub workflow is well explained, it doesn't document a) How to contribute - improve documentation/add new methods/improve performance. Please let me know if you need any help or information. Also it might be better to document the overview of code structure and API can be written in a separate document rather than this. You can leave that section at this time. Thank you for your contribution. |
|
@vibrantabhi19, can you please update on this? Thanks. |
|
Sure. Will do it within a day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the following points mentioned in Issue #14
a) How to contribute - improve documentation/add new methods/improve performance.
b) Explain contribution workflow - issues/pull-request/review.
Have a look and then I will proceed with the next.