Updated dependency of phpunit #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the version of dependency from phpunit to avoid conflicts.
|
Will this be merged? |
|
The dependency "satooshi/php-coveralls": "~1.0" needs "phpunit/phpunit: ^4.8.35 || ^5.4.3 || ^6.0", so the composer.json containing the dependency " "phpunit/phpunit": "4.*"," causes a conflict that is corrected by this PR. |
|
@royopa i understand, I was trying to nudge @andrejsstepanovs to merge it 👍 |
andrejsstepanovs
approved these changes
Apr 6, 2018
|
Please check why travis failed! |
andrejsstepanovs
requested changes
Apr 6, 2018
There was a problem hiding this comment.
@royopa Please try out your composer.json changes. Travis build said:
[UnexpectedValueException] Could not parse version constraint ~4.*: Invalid version string "~4.*"
royopa
commented
Apr 6, 2018
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the version of dependency from phpunit to avoid conflicts.