Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding length to PrintMessage and get data as dictionary #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adding length to PrintMessage and get data as dictionary #1

wants to merge 3 commits into from

Conversation

aguirrel
Copy link

Hi!

First all, thanks for this great lib!

I did some changes that could be useful.

This PR has 3 things:

  • Addes length to text printed in PrintMessage.
  • Added DictMessage to class to get all data as dictionary.
  • Fixes some odd error on importing IsoSpecs

Best regards,

@alxnik
Copy link
Owner

alxnik commented Nov 19, 2016

Thanks for taking the time to improve the library. I'll try to find some time review the PR

@rjarce
Copy link

rjarce commented Dec 12, 2016

Hi!

Seconding this pull request. Commit 58a0a9f fixes import problems from external apps/modules.

Thanks, @alxnik and @aguirrel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aguirrel @alxnik @rjarce