Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPIKE] Check all pages' accessibility #2957

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

[SPIKE] Check all pages' accessibility #2957

wants to merge 12 commits into from

Commits on Jul 15, 2024

  1. [SPIKE] Check all pages accessibility

    @domoscargin
    domoscargin committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    bbc8e49 View commit details
    Browse the repository at this point in the history

  2. Gather accessibility test URLs using glob

    @colinrotherham @domoscargin
    colinrotherham authored and domoscargin committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    8371cc2 View commit details
    Browse the repository at this point in the history

  3. Group Axe excludes into array

    @colinrotherham @domoscargin
    colinrotherham authored and domoscargin committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    67209b1 View commit details
    Browse the repository at this point in the history

  4. Add Axe rules/reporting from GOV.UK Frontend 

    See: alphagov/govuk-frontend@ebb9e4e
    @colinrotherham @domoscargin
    colinrotherham authored and domoscargin committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    e127cc8 View commit details
    Browse the repository at this point in the history

  5. Add Puppeteer options from GOV.UK Frontend

    @colinrotherham @domoscargin
    colinrotherham authored and domoscargin committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    06bbb64 View commit details
    Browse the repository at this point in the history

  6. Run each accessibility test in a new page

    @colinrotherham @domoscargin
    colinrotherham authored and domoscargin committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    f0e1981 View commit details
    Browse the repository at this point in the history

  7. Split out excludes, and globs 

    It might be an axe bug, but exclude doesn't seem to work properly with an array argument. Splitting them out reduces failures from 300+ to 139.

Additionally, I've made some changes to which files are included in the glob, with a view to splitting these out and only running certain tests in certain environments to avoid jammingthings up for too long.
    @domoscargin
    domoscargin committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    69eb349 View commit details
    Browse the repository at this point in the history

  8. Add pattern indexes

    @domoscargin
    domoscargin committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    9bb8381 View commit details
    Browse the repository at this point in the history

  9. [WIP] Fix accessibility failures

    @domoscargin
    domoscargin committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    4d4d44f View commit details
    Browse the repository at this point in the history

  10. Adjust heading order

    @domoscargin
    domoscargin committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    2161784 View commit details
    Browse the repository at this point in the history

  11. Remove unneeded exclusion

    @domoscargin
    domoscargin committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    1355943 View commit details
    Browse the repository at this point in the history

  12. Fix aria-allowed-role failure 

    This was done on purpose in #304, but unclear if it still applies?
    @domoscargin
    domoscargin committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    969033f View commit details
    Browse the repository at this point in the history