Fix index name generation #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
fix-index-name-generation
branch
from
5bb3e65
to
4b04164
Compare
|
Test failures are unrelated, ignoring for now. |
kirkbaly
pushed a commit
to HealthCall-Dev/mongo-php-adapter
that referenced
this pull request
Jan 4, 2024
* Improve testing (alcaeus#293) * Run workflows every Sunday * Remove failing seed list test * Add instrumentation when connecting * Use Ubuntu 20.04 for tests (alcaeus#302) * Use internal class instead of now-removed internal function (alcaeus#301) * PHP 8.2 compatibility - deprecation notice fix (alcaeus#306) * Avoid using private API to fix regression (alcaeus#307) --------- Co-authored-by: Andreas Braun <[email protected]> Co-authored-by: Andreas Braun <[email protected]> Co-authored-by: Stevan Tosic <[email protected]>
andyputra0712
added a commit
to GDP-ADMIN/kaskus-mongo-php-adapter
that referenced
this pull request
Jun 13, 2024
* Improve testing (alcaeus#293) * Run workflows every Sunday * Remove failing seed list test * Add instrumentation when connecting * Use Ubuntu 20.04 for tests (alcaeus#302) * Use internal class instead of now-removed internal function (alcaeus#301) * PHP 8.2 compatibility - deprecation notice fix (alcaeus#306) * Avoid using private API to fix regression (alcaeus#307) * PHP8.2 Dependency * revert old changes overriden by new commit --------- Co-authored-by: Andreas Braun <[email protected]> Co-authored-by: Andreas Braun <[email protected]> Co-authored-by: Stevan Tosic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #300. The internal
MongoDB\generate_index_namemethod was removed in version 1.16.0 of the MongoDB driver. To work around this,MongoCollectionnow uses the internalIndexInputclass to generate index names.