Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate DPD to new roulier and python 3 #139

Merged
merged 4 commits into from
Mar 26, 2021
Merged

Conversation

DylannCordel
Copy link
Contributor

@DylannCordel DylannCordel commented Jan 20, 2021

dpd has been renamed to dpd_fr_soap because this webservice is specific to France (and _soap as discussed in #138 and #140). I also have a dpd_sk_rest available if someone is interrested but I don't have any credentials to test it (it seems each country have it's own webservice)

@DylannCordel
Copy link
Contributor Author

@florian-dacosta PR is ready to be reviewed. If you want to run tests, you need to ask to DPD France they allow your IP to access their test server.

@florian-dacosta
Copy link
Member

Thanks for your work again.
For you information, DPD should change its webservice. It was planned for 2019 though, but they were not ready, but they still should do it sooner or later.
Here is the work that was done to meet their new webservice : https://github.com/akretion/roulier/tree/feat/dpd_2019
Not used yet, just so you know. We will probably need to switch when they will be ready.

@DylannCordel
Copy link
Contributor Author

DylannCordel commented Feb 22, 2021

@florian-dacosta code rebased and dpd_fr renamed to dpd_fr_soap (as discussed in #138 and #140)

@florian-dacosta
Copy link
Member

@DylannCordel
I didnt notice the PR was not up to date with master.
Merging it did break it because the last refactore here : ba5640c#diff-e2b8c9f0fa9c6966e5cb30dd546c57d799f60206afda0c7e15c85b915020bc8aR15

I made a fix, so all should be ok. But please, be careful if you update roulier and switch back to master for DPD, you should first confirm all is working properly.

@DylannCordel
Copy link
Contributor Author

@florian-dacosta LGFM : tests are running from an allowed IP. We may ask to DPD to allow travis IPs for the test account or create a specific test account for roulier ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants