-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate DPD to new roulier and python 3 #139
Conversation
@florian-dacosta PR is ready to be reviewed. If you want to run tests, you need to ask to DPD France they allow your IP to access their test server. |
Thanks for your work again. |
@florian-dacosta code rebased and dpd_fr renamed to dpd_fr_soap (as discussed in #138 and #140) |
@DylannCordel I made a fix, so all should be ok. But please, be careful if you update roulier and switch back to master for DPD, you should first confirm all is working properly. |
@florian-dacosta LGFM : tests are running from an allowed IP. We may ask to DPD to allow travis IPs for the test account or create a specific test account for roulier ? |
dpd
has been renamed todpd_fr_soap
because this webservice is specific to France (and_soap
as discussed in #138 and #140). I also have adpd_sk_rest
available if someone is interrested but I don't have any credentials to test it (it seems each country have it's own webservice)