Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added types to private functions, improved readability, shouldCheckProxyHeaders as separate function #43

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

akrabat
Copy link
Owner

@akrabat akrabat commented Jun 9, 2024

This is #38 with main merged into it.

Proposed some minor improvements/changes:

  • added argument and return types to private functions parseWildcard, parseCidr, getFirstIpAddressFromHeader
  • improved isValidIpAddress function readability
  • moved determining whether proxy headers should be checked to separate shouldCheckProxyHeaders function

@akrabat akrabat added this to the 2.2 milestone Jun 9, 2024
@akrabat akrabat merged commit 5e3b94b into main Jun 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants