Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(source-linkedin-ads): migrate to low-code #44370

Merged
merged 104 commits into from
Sep 19, 2024

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Aug 18, 2024

What

On 08/01, the LinkedIn Ads source connector was fully migrated to a low-code and it’s affecting 4 connections in different ways.

Resolves https://github.com/airbytehq/oncall/issues/6198
Resolves https://github.com/airbytehq/oncall/issues/6205
Resolves https://github.com/airbytehq/oncall/issues/6207
Resolves https://github.com/airbytehq/oncall/issues/6208

How

  • Updated the schema from campaign_groups to campaigns to ensure accurate discovery of campaigns stream.
  • Added page_token_option and page_size_option to the manifest to correctly handle pagination.
  • Format of the state has changed from global to per-partition

Review guide

  1. manifest.yaml
  2. source.py

User Impact

No

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

lazebnyi and others added 30 commits May 17, 2024 17:28
…f github.com:airbytehq/airbyte into lazebnyi/7804-source-linkedin-ads-migrate-to-lowcode
…f github.com:airbytehq/airbyte into lazebnyi/7804-source-linkedin-ads-migrate-to-lowcode
…kedin_ads/config_migrations.py

Co-authored-by: Artem Inzhyyants <[email protected]>
@lazebnyi lazebnyi requested review from artem1205 and removed request for a team September 11, 2024 06:16
Copy link
Collaborator

@artem1205 artem1205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@girarda
Copy link
Contributor

girarda commented Sep 13, 2024

@lazebnyi the regression test report you shared shows some differences between the previous version and the latest one. is this expected?

Item root['properties']['_pivot'] added to dictionary.
Item root['properties']['pivot'] removed from dictionary.
Item root['required'][0] added to iterable.
Item root['required'][1] removed from iterable.

It looks like a field was renamed from pivot to _pivot

@lazebnyi
Copy link
Collaborator Author

@girarda Yes, this has already been fixed, and I've also renamed this field to 'pivot' - 117106f

Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @lazebnyi ! ✅

@lazebnyi lazebnyi merged commit d9e33f3 into master Sep 19, 2024
37 of 40 checks passed
@lazebnyi lazebnyi deleted the lazebnyi/source-linkedin-ads-fix-low-code-migration branch September 19, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/linkedin-ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants