-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(source-linkedin-ads): migrate to low-code #44370
refactor(source-linkedin-ads): migrate to low-code #44370
Conversation
…f github.com:airbytehq/airbyte into lazebnyi/7804-source-linkedin-ads-migrate-to-lowcode
…f github.com:airbytehq/airbyte into lazebnyi/7804-source-linkedin-ads-migrate-to-lowcode
airbyte-integrations/connectors/source-linkedin-ads/metadata.yaml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-linkedin-ads/source_linkedin_ads/config_migrations.py
Outdated
Show resolved
Hide resolved
…kedin_ads/config_migrations.py Co-authored-by: Artem Inzhyyants <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
airbyte-integrations/connectors/source-linkedin-ads/source_linkedin_ads/config_migrations.py
Show resolved
Hide resolved
@lazebnyi the regression test report you shared shows some differences between the previous version and the latest one. is this expected?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @lazebnyi ! ✅
What
On 08/01, the LinkedIn Ads source connector was fully migrated to a low-code and it’s affecting 4 connections in different ways.
Resolves https://github.com/airbytehq/oncall/issues/6198
Resolves https://github.com/airbytehq/oncall/issues/6205
Resolves https://github.com/airbytehq/oncall/issues/6207
Resolves https://github.com/airbytehq/oncall/issues/6208
How
campaign_groups
to campaigns to ensure accurate discovery of campaigns stream.page_token_option
andpage_size_option
to the manifest to correctly handle pagination.Review guide
manifest.yaml
source.py
User Impact
No
Can this PR be safely reverted and rolled back?