Update access-control.rst #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed minor spelling typos and added phrases for clarity.
yvsssantosh
reviewed
Aug 7, 2021
| - Only an authenticated user can create a choice. | ||
| - Authenticated users can create choices only for polls they have created. | ||
| - Authenticated users can delete only polls they have created. | ||
| - Only an authenticated user can vote. Users can vote for other people's polls. | ||
| - Only an authenticated user can vote. Authenticated users can vote on other people's polls. |
There was a problem hiding this comment.
Only an authenticated user can vote. They can also vote on other people's polls
yvsssantosh
reviewed
Aug 7, 2021
| Which give back this response. | ||
| Doing so gives back this response. |
There was a problem hiding this comment.
Which gives back this response:
or
Which returns the response below
yvsssantosh
reviewed
Aug 7, 2021
| Note the :code:`authentication_classes = ()` and :code:`permission_classes = ()` to exempt :code:`UserCreate` from global authentication scheme. | ||
| Note the :code:`authentication_classes = ()` and :code:`permission_classes = ()` statements which exempt :code:`UserCreate` from the global authentication scheme. |
yvsssantosh
reviewed
Aug 7, 2021
|
|
||
| We want to ensure that tokens are created when user is created in :code:`UserCreate` view, so we update the :code:`UserSerializer`. Change your :code:`serializers.py` like this | ||
| To ensure that tokens are created when a user is created in the :code:`UserCreate` view, we need to update the :code:`UserSerializer`. Edit your :code:`serializers.py` to accomodate this change. |
There was a problem hiding this comment.
Edit your serializers.py as explained below:
yvsssantosh
reviewed
Aug 7, 2021
| POST with a incorrect username and password, and you will get a response like this, with a HTTP status of 400. | ||
| Do a POST with a incorrect username and password, and you will get a response like this, with a HTTP status of 400. |
There was a problem hiding this comment.
Revert and update:
POST with an incorrect username and password, and you will get a response like this, with a HTTP status of 400.
|
Make the changes as mentioned. And I should be able to merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed minor spelling typos and added phrases for clarity. Thanks.