Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First activity report fields #55

Merged
merged 8 commits into from
Oct 27, 2020
Merged

Conversation

jasalisbury
Copy link

@jasalisbury jasalisbury commented Oct 26, 2020

Description of change

  • Add first fields to activity report
  • Remove stepper and stepper related code

Kept the form split into separate files even though they all show on the same page to help with readability.

Limitations

  • multiselect dropdowns currently only allow a single selection, I'm working on getting multiselect component added to the frontend.
  • Validations are not present for the most part. Those will be added once we know how messages should be shown.
  • Local saving of the form state. Any reload or page navigation will clear out the form when it is reloaded.

How to test

  1. Browse to https://tta-smarthub-sandbox.app.cloud.gov
  2. Login and go to the activity reports tab

Issue(s)

Checklist

  • Meets issue criteria
  • Code tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • Documentation updated

 * Stepper is removed for now. We will need to support out of order form
entry, which the stepper doesn't support (and can't easily be updated to
do so)
 * Add skip link
 * Add navigation landmark
 * Activity report has proper heading structure
Copy link
Collaborator

@SarahJaine SarahJaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for deploying this to sandbox. It was really helpful to be able to play around with the form. I don't think I know enough about FE to give more than a comment review. I did have a question/suggestion about those form consts though. Overall, this looks great!

.circleci/config.yml Show resolved Hide resolved
frontend/src/components/__tests__/DatePicker.js Outdated Show resolved Hide resolved
frontend/src/pages/ActivityReport/index.js Show resolved Hide resolved
@kryswisnaskas
Copy link
Collaborator

Very nice! Strong work! 👍

Do you think we could a couple of happy path cucumber tests? Maybe something along the lines of "When I press Activity Reports" I see "New report...." heading; "When I select non-grantee", I see "QRIS System" as an option" in the "Who was this activity for" dropdown.

@jasalisbury jasalisbury merged commit 5d9976a into main Oct 27, 2020
@jasalisbury jasalisbury deleted the js-81-first-activity-report-fields branch October 27, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants