Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmake install steps #41

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Add cmake install steps #41

merged 1 commit into from
Feb 28, 2024

Conversation

uilianries
Copy link
Contributor

Hello!

Conan is packaging your project here: conan-io/conan-center-index#22891 to be distributed as a public package. As we using CMake to execute most of step, we found the install step missing.

This PR adds a new configuration to install headers and libraries when executing cmake --build build --target install:

$ cmake -S . -B build -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=/tmp/install 
...   
$ cmake --build build --target install                                                                                                                                                                                                     10:28:18
[ 11%] Built target ada-idna
[ 22%] Built target punycode_tests
[ 33%] Built target to_ascii_tests
[ 44%] Built target mapping_tests
[ 55%] Built target to_unicode_tests
[ 66%] Built target simdjson
[ 77%] Built target wpt_tests
[ 83%] Built target singleheader-files
[100%] Built target demo
Install the project...
-- Install configuration: "Debug"
-- Installing: /tmp/install/lib/libada-idna.a
-- Installing: /tmp/install/include/idna.h
-- Installing: /tmp/install/include/ada
-- Installing: /tmp/install/include/ada/idna
-- Installing: /tmp/install/include/ada/idna/normalization.h
-- Installing: /tmp/install/include/ada/idna/mapping.h
-- Installing: /tmp/install/include/ada/idna/punycode.h
-- Installing: /tmp/install/include/ada/idna/validity.h
-- Installing: /tmp/install/include/ada/idna/to_ascii.h
-- Installing: /tmp/install/include/ada/idna/unicode_transcoding.h
-- Installing: /tmp/install/include/ada/idna/to_unicode.h

Signed-off-by: Uilian Ries <[email protected]>
@lemire lemire merged commit fff9885 into ada-url:main Feb 28, 2024
16 of 17 checks passed
@lemire
Copy link
Member

lemire commented Feb 28, 2024

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants