Interactivity API: Correctly handle lazily added, deeply nested properties in context #65465

michalczaplinski · 2024-09-18T18:31:44Z

@DAreRodz both of those assertions fail:

expect( spy ).toHaveBeenCalledTimes( 2 );

Expected number of calls: 2 Received number of calls: 1

expect( deepValue ).toBe( 'test value' );

Expected: "test value" Received: undefined

But I'm not 100% sure if those are precisely the failures we wanted to see.

Thanks for the PR, @michalczaplinski. 😁

I'm not 100% sure if those are precisely the failures we wanted to see.

They are. The values received are the same as those returned in the initial call. Basically, the spy function has not been executed again because the signal for context.a has not been updated.

I had to stare at the test a little longer to convince myself that it was actually the case 😅.

Excellent, I'll add the fix tomorrow 🙂

-Original file line number
+Diff line change
@@ Expand Up / @@ -277,6 +277,30 @@ @@
     					'fromFallback',
     				] );
     			} );
+    			it( 'should handle deeply nested properties that are initially undefined', () => {
+    				const context: any = proxifyContext( {}, {} );
+    				let deepValue: any;
+    				const spy = jest.fn( () => {
+    					deepValue = context.a?.b?.c?.d;
+    				} );
+    				effect( spy );
+    				// Initial call, the deep value is undefined
+    				expect( spy ).toHaveBeenCalledTimes( 1 );
+    				expect( deepValue ).toBeUndefined();
+    				// Add a deeply nested object to the context
+    				context.a = { b: { c: { d: 'test value' } } };
+    				// The effect should be called again
+    				expect( spy ).toHaveBeenCalledTimes( 2 );
+    				expect( deepValue ).toBe( 'test value' );
+    				// Reading the value directly should also work
+    				expect( context.a.b.c.d ).toBe( 'test value' );
+    			} );
     		} );
     		describe( 'proxifyContext', () => {
@@ Expand Down @@

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Interactivity API: Correctly handle lazily added, deeply nested properties in context #65465

Diff view

Diff view

There are no files selected for viewing

GitHub Actions / JavaScript (Node.js 20) 2/4

GitHub Actions / JavaScript (Node.js 22) 2/4

michalczaplinski Sep 18, 2024

DAreRodz Sep 18, 2024

michalczaplinski Sep 18, 2024

Interactivity API: Correctly handle lazily added, deeply nested properties in context #65465

Are you sure you want to change the base?

Interactivity API: Correctly handle lazily added, deeply nested properties in context #65465

Diff view

Diff view

There are no files selected for viewing

GitHub Actions / JavaScript (Node.js 20) 2/4

GitHub Actions / JavaScript (Node.js 22) 2/4

michalczaplinski Sep 18, 2024

Choose a reason for hiding this comment

DAreRodz Sep 18, 2024

Choose a reason for hiding this comment

michalczaplinski Sep 18, 2024

Choose a reason for hiding this comment