Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helper/linuxkeyring: use configured pass directory #763

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eonpatapon
Copy link

When the keyring package is configured and PassDir is empty it will
default to ~/.password-store/.

See https://github.com/99designs/keyring/blob/master/pass.go#L26

Closes #440

When the keyring package is configured and PassDir is empty it will
default to ~/.password-store/.

Closes Versent#440
@tinaboyce
Copy link
Contributor

hi @eonpatapon , is this PR still relevant? I've noticed the issue this PR meant to close on merge is already closed.

@eonpatapon
Copy link
Author

@tinaboyce I don't know, I don't use saml2aws anymore sorry..

@eonpatapon
Copy link
Author

By looking at the current code I believe the issue still exists

@tinaboyce
Copy link
Contributor

Ah okay, thanks for checking up on it for me.

I'll keep this issue open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete
2 participants