Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle FCMv1 responses #69

Merged
merged 1 commit into from
Jun 16, 2024
Merged

Handle FCMv1 responses #69

merged 1 commit into from
Jun 16, 2024

Conversation

moffatman
Copy link
Contributor

They have a different shape. Notifications did go through before this commit, but the system calling common-proxies always got a 502 code.

Since the old API is gonna be turned off in a few days; I didn't handle both; just the new one.

They have a different shape. Notifications did go through before this commit,
but the system calling common-proxies always got a 502 code.

Since the old API is gonna be turned off in a few days; I didn't
handle both; just the new one.
@moffatman
Copy link
Contributor Author

@p1gp1g @karmanyaahm

@p1gp1g
Copy link
Member

p1gp1g commented Jun 16, 2024

Thanks a lot. Is everything correctly working after this commit for you ?

@p1gp1g p1gp1g merged commit 24a6fa7 into UnifiedPush:main Jun 16, 2024
1 check passed
@moffatman
Copy link
Contributor Author

On my dev machine yeah. But I haven't built amd64 Linux yet to try on my actual app. Was waiting for your release as too lazy to set up "go" build system for Linux.

@p1gp1g
Copy link
Member

p1gp1g commented Jun 16, 2024

I've tested, it works great. Thanks again.

We should probably update the doc to help to set this up. For those looking for the right credentials file:

  1. Go to your firebase console, then to IAM-Admin > Service accounts (https://console.cloud.google.com/iam-admin/serviceaccounts)
  2. Create a new service account with Firebase Messaging API administration rights
  3. Then generate a new key for this account

@moffatman
Copy link
Contributor Author

Thx. is it possible you can do a release to get the linux build?

@p1gp1g
Copy link
Member

p1gp1g commented Jun 16, 2024

Sure. It is building

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants