Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat:constant loading improvements #6

Merged
merged 3 commits into from
Aug 3, 2023
Merged

Conversation

Uaitt
Copy link
Owner

@Uaitt Uaitt commented Aug 3, 2023

In this PR I provide a new way of loading constants for AASM RBS.

Description

In this PR:

  • executable must be called at the root of the project directory now.
  • while dealing with a Rails project constants are loaded with the Rake::Task[:environment] task, while dealing with a pure-ruby project the file is required manually.
  • documentation was updated to reflect the new changes and to be more expressive. Badges have been added too.
  • configure rbs_collection to load 3rd party RBS dependencies.

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Uaitt Uaitt added the enhancement New feature or request label Aug 3, 2023
@Uaitt Uaitt self-assigned this Aug 3, 2023
@Uaitt Uaitt force-pushed the fix/constant-loading-issues branch 4 times, most recently from 7c3fcc8 to 2abd95d Compare August 3, 2023 15:29
@Uaitt Uaitt force-pushed the fix/constant-loading-issues branch from 2abd95d to a06f2dc Compare August 3, 2023 15:31
@Uaitt Uaitt force-pushed the fix/constant-loading-issues branch from 93f8afa to 844e324 Compare August 3, 2023 15:34
@Uaitt Uaitt merged commit 631ceef into main Aug 3, 2023
5 checks passed
@Uaitt Uaitt deleted the fix/constant-loading-issues branch August 3, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant