Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query-core): export partialMatchKey util #7883

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(query-core): export partialMatchKey util #7883

wants to merge 3 commits into from
+14 −0

Conversation

raidenmiro
Copy link

@raidenmiro raidenmiro commented Aug 10, 2024 •
edited
Loading

#4355

This pull request exports the utility, which is very useful for a key match.

@github-actions github-actions bot added documentation Improvements or additions to documentation package: query-core labels Aug 10, 2024
@raidenmiro raidenmiro changed the title feat: export partialMatchKey util feat(query-core): export partialMatchKey util Aug 10, 2024
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Sep 8, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d6dca60. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 8, 2024

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7883

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@7883

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@7883

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@7883

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7883

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@7883

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@7883

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@7883

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@7883

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@7883

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@7883

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@7883

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@7883

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@7883

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@7883

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@7883

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@7883

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@7883

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@7883

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@7883

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@7883

commit: d6dca60

@TkDodo
Copy link
Collaborator

TkDodo commented Sep 8, 2024

sorry I've been thinking about it some more and isn't it enough that we already export the machQuery function?

@codecov Codecov
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.85%. Comparing base (9b78527) to head (d6dca60).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #7883       +/-   ##
=========================================
+ Coverage      0   61.85%   +61.85%     
=========================================
  Files         0      135      +135     
  Lines         0     4680     +4680     
  Branches      0     1303     +1303     
=========================================
+ Hits          0     2895     +2895     
- Misses        0     1543     +1543     
- Partials      0      242      +242
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 86.58% <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 92.86% <ø> (∅)
@tanstack/query-devtools 4.86% <ø> (∅)
@tanstack/query-persist-client-core 57.73% <ø> (∅)
@tanstack/query-sync-storage-persister 82.50% <ø> (∅)
@tanstack/react-query 92.50% <ø> (∅)
@tanstack/react-query-devtools 10.00% <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (∅)
@tanstack/solid-query 78.20% <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (∅)
@tanstack/svelte-query 87.33% <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (∅)
@tanstack/vue-query 71.51% <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation package: query-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raidenmiro @TkDodo