Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds clickhouse resource #132

Merged
merged 7 commits into from
Aug 28, 2023
Merged

Adds clickhouse resource #132

merged 7 commits into from
Aug 28, 2023

Conversation

PascalSenn
Copy link
Member

@PascalSenn PascalSenn commented Aug 19, 2023 •
edited
Loading

Adds Clickhouse resource

joslat
joslat approved these changes Aug 21, 2023
View reviewed changes
Copy link

@joslat joslat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!
The only minor thing are a couple of new HttpClient... but maybe there is a reason for those... otherwise I'd use HttpClientFactory, on the rest all good, very clean code

src/ClickHouse/ClickHouseResource.cs Show resolved Hide resolved
@glucaci
Copy link
Member

glucaci commented Aug 25, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@glucaci glucaci merged commit e55a5e9 into master Aug 28, 2023
2 of 3 checks passed
@glucaci glucaci deleted the pse/adds-clickhouse-resource branch August 28, 2023 11:27
@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability E 1 Vulnerability
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joslat joslat joslat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PascalSenn @glucaci @joslat