Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/2234 fixing sqlite #2389

Merged
merged 3 commits into from
Sep 4, 2024
Merged

bug/2234 fixing sqlite #2389

merged 3 commits into from
Sep 4, 2024

Conversation

engelhartrueben
Copy link
Collaborator

@engelhartrueben engelhartrueben commented Jul 24, 2024 •
edited
Loading

Fixes # (issue)

Fixes #2234

Description

First bug fixes a .timeout() knex function call that doesn't support sqlite.
Second bug fixes datetime being passed as a string, and not a date object

SPECIAL THANKS TO @schuyler1d

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@engelhartrueben engelhartrueben marked this pull request as ready for review July 26, 2024 13:57
mau11
mau11 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@mau11 mau11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@engelhartrueben engelhartrueben merged commit 74558a6 into stage-main-14.1 Sep 4, 2024
17 checks passed
@engelhartrueben engelhartrueben deleted the re/fix-sqlite branch September 4, 2024 13:43
@engelhartrueben engelhartrueben mentioned this pull request Sep 4, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mau11 mau11 mau11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@engelhartrueben @mau11