Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decreased conditions for amix_out_cur to amix_out assignment. #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

esden
Copy link
Contributor

@esden esden commented Nov 12, 2019

The alphamixer_out <= alphamixer_out_cur can be done outside of the
state machine as it is an output dependent on the vid_wen bit. It very
slightly improves the timing for clk48m from 49.36 MHz to 49.74 MHz.

I will be adding another combinatorial step in that output path as part
of the workshop. In that case this change make a huge timing difference
fail vs pass. Having this minor change will make the workshop bit less
convoluted and easier to follow.

Of course I might be missing something and this is a terrible idea. Please let me know. :D

The alphamixer_out <= alphamixer_out_cur can be done outside of the
state machine as it is an output dependent on the vid_wen bit. It very
slightly improves the timing for clk48m from 49.36 MHz to 49.74 MHz.

I will be adding another combinatorial step in that output path as part
of the workshop. In that case this change make a huge timing difference
fail vs pass. Having this minor change will make the workshop bit less
convoluted and easier to follow.
@Spritetm
Copy link
Owner

Sorry for taking so long to merge this... I think I recall there may be an edge case here somewhere as the entire pixel pipeline is pretty pipelined but sometimes needs to stop because copper or DMA wait, but I haven't found the time to properly look into this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants