Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes leaky savedInputChecked across multiple instances #2369

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

daftspunk
Copy link

@daftspunk daftspunk commented Apr 30, 2024

Steps to Reproduce Issue

  1. Create two sortables on the same page: List A and List B

  2. The options.handle must be specified for some reason

  3. Add an event when a checkbox is unchecked inside List A

  4. Set event to destroy and replace SortableJS on List B

Problem

All checkboxes on List A are rechecked when List B is rebound (via _nulling)

SortableJS-Bug

Expectation

The checkbox should remain unchecked

Proposed Fix

It seems to happen because savedInputChecked is a global instance. So List B's store will contain List A's checkboxes...

The proposed code ensures the checkboxes remain within the scope of the relevant instance.

Related

This may be a solution to #1052's continuation since people are still suggesting it's broken.

It could be why you can't reproduce it, since two SortableJS instances are needed to produce the collision/outcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant