Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add detection conditions of whether to correct the position #1952

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

zjffun
Copy link
Contributor

@zjffun zjffun commented Oct 30, 2020

I find it also need to correct position when its parents' perspective or filter property set to something other than none.

Reproduction: https://codepen.io/1010543618/pen/jOrZQXq

See: position - CSS: Cascading Style Sheets | MDN

waynevanson and others added 30 commits August 7, 2020 15:27
…ortableJS#1875)

* deps: install dev-deps for ts, tests and friends

* tests: replace test.js with test.ts and fp

* change compat tests

* ci: replace tests to use npm as per usual
…1878)

The doc was missing the case of keeping the default insertion point based on the direction.
* refactor(tests): move HTML fixtures into own dir

* refactor(tests): separate e2e tests into folders

* refactor(deps): packagejson reformat

* refactor(deps): remove cypress from dev deps

* refactor(ci): add description to circleci
* refactor(tests): move HTML fixtures into own dir

* refactor(tests): separate e2e tests into folders

* refactor(deps): packagejson reformat

* refactor(deps): remove cypress from dev deps

* refactor(ci): add description to circleci

* build: bundles with rollup ^2.14 and typescript

* dist: create new dist files

* chore: bump minor version

* build(refactor): removes unused babel plugin
* build: upgrade to 1.11.0

* tests(fix): emit exit code 1 on fail
* build: upgrade to 1.11.0

* tests(fix): emit exit code 1 on fail

* refactor: microbundle and typescript

* ci: ensure lerna is globally available

* build: use yarn and workspaces

* use lerna

* build: add private to sortbale repo

* v1.11.1

* ci: use yarn and lerna together

* fix ci

* tests: fix tests
…S#1914)

* refactor: remove code formattings config files

* docs: add more detail to contribution guidelines

* docs: remove custom templates

* docs: update bug report issue

* docs: add discussion template

* docs: update featue template
…-links

Readme invalid hyperlinks corrected
…ableJS#1921)

* refactor: remove code formattings config files

* docs: add more detail to contribution guidelines

* docs: remove custom templates

* docs: update bug report issue

* docs: add discussion template

* docs: update featue template

* fix(build): build dist/sortablejs, was missing prior

* build(deps): yarn upgrade

* v1.11.2-alpha.4
* refactor: remove code formattings config files

* docs: add more detail to contribution guidelines

* docs: remove custom templates

* docs: update bug report issue

* docs: add discussion template

* docs: update featue template

* fix(build): build dist/sortablejs, was missing prior

* build(deps): yarn upgrade

* v1.11.2-alpha.4
* refactor: remove code formattings config files

* docs: add more detail to contribution guidelines

* docs: remove custom templates

* docs: update bug report issue

* docs: add discussion template

* docs: update featue template

* fix(build): build dist/sortablejs, was missing prior

* build(deps): yarn upgrade

* v1.11.2-alpha.4

* fix(build): exports modules correctly

This was broken, visible, and closes SortableJS#1891.
* Create composer.json

* Change project name in composer.json

* Fix authors listed in composer.json

* Update repo source in composer.json

Co-authored-by: Wayne Van Son <[email protected]>

* Update "issues" link in composer.json

Co-authored-by: Wayne Van Son <[email protected]>

* Update homepage link in composer.json

Co-authored-by: Wayne Van Son <[email protected]>

* Update package name in composer.json

Co-authored-by: Wayne Van Son <[email protected]>

* Remove legacy file from composer.json files list

Co-authored-by: Derek DeRaps <[email protected]>
Co-authored-by: Wayne Van Son <[email protected]>
Fix IE11 "SCRIPT16389: Unspecified error." when dragging element

Could not pull in SortableJS#1904 due to merge errors, so this PR was created instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants